Skip to content

pyopenssl: Disable flaky test_wantWriteError test.#50294

Closed
nh2 wants to merge 1 commit intoNixOS:stagingfrom
nh2:pyopenssl-disable-flaky-test_wantWriteError
Closed

pyopenssl: Disable flaky test_wantWriteError test.#50294
nh2 wants to merge 1 commit intoNixOS:stagingfrom
nh2:pyopenssl-disable-flaky-test_wantWriteError

Conversation

@nh2
Copy link
Contributor

@nh2 nh2 commented Nov 13, 2018

Works around pyca/pyopenssl#768

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@nh2 nh2 requested a review from FRidh as a code owner November 13, 2018 02:40
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 13, 2018
@nh2
Copy link
Contributor Author

nh2 commented Nov 13, 2018

CC @dtzWill from #42180 (comment)

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Nov 13, 2018
@FRidh FRidh changed the base branch from master to staging July 20, 2019 11:39
@FRidh
Copy link
Member

FRidh commented Jul 20, 2019

Needs a rebase. Please reopen if interested in getting this in. I think it's fine.

@FRidh FRidh closed this Jul 20, 2019
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 20, 2019
@nh2
Copy link
Contributor Author

nh2 commented Jul 20, 2019

@FRidh Rebased, reopening

@nh2
Copy link
Contributor Author

nh2 commented Jul 20, 2019

@FRidh I clicked Reopen and comment but it only commented; it's still marked as Closed and now the Reopen and comment button is permanently greyed out.

@nh2 nh2 mentioned this pull request Jul 20, 2019
Merged
@nh2
Copy link
Contributor Author

nh2 commented Jul 20, 2019

Looks like a Github bug to me, so I made a new one in #65160 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nh2 @FRidh @GrahamcOfBorg